salesforce Add support for asyncMode in bulk operation
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtuchi
changed the title
salesforce Add support for asyncMode in bulk operation
| if (asyncMode) { | ||
| return batch.on('queue', async function (batchInfo) { | ||
| console.info('Batch queued. Batch ID:', batchInfo.id); | ||
| resolve({ batchInfo }); |
There was a problem hiding this comment.
A promise can only resolve once. If there are multiple queue events, for multiple chunks, then they'll never report back to user code. In other words, we'll only ever report back the first batch here.
There was a problem hiding this comment.
🤔 I have tried running the test with a batch size of 1 and i got the expected results.
Can you tell me more about this ?
There was a problem hiding this comment.
I have tested multiple batches by reducing the batch size to 1 and run integration test that insert two records with the option asynMode: true, I can see that i am getting two batches records after the bulk operation is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
asyncModeoption in bulk operation. If you don't provided this extraasyncModeoption, we return all record info tostate.dataas we currently do.Fixes #286
Details
asyncModeistruewe returnbatchInfo{ success: true, batches: [], errors: []}ifasyncMode: truestate.data.batchesasyncMode: trueAI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.