Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ContentIndicator validation should be on "name", not on "type". #974

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

decarteret
Copy link
Collaborator

@decarteret decarteret commented Feb 5, 2025

Prior implementation was ensuring only one indicator "type" per collection which is not correct.

The goal is to have:

  • all the items from contentIndicators
  • all the items from defaultContentIndicators that aren't in contentIndicators
  • the defaultContentIndicators should be first

This PR produces the correct calculation.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@decarteret decarteret self-assigned this Feb 5, 2025
@josephjclark
Copy link
Collaborator

@decarteret I've pushed some commits to fix some test failures in CI.

Could you please run pnpm changeset from root and follow the prompt to generate a public release note for the change? This looks like a patch version to me.

Jason DeCarteret and others added 2 commits February 5, 2025 08:38
@josephjclark josephjclark merged commit 80ec7dc into main Feb 5, 2025
2 checks passed
@josephjclark josephjclark deleted the gmail-indicators-fix branch February 5, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants