Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASVS: password length to 12 #2507

Merged
merged 5 commits into from
Sep 20, 2024
Merged

ASVS: password length to 12 #2507

merged 5 commits into from
Sep 20, 2024

Conversation

taylordowns2000
Copy link
Member

@taylordowns2000 taylordowns2000 commented Sep 17, 2024

Note that after this gets shipped to demo in a release, we must merge this: OpenFn/docs#571

Description

This PR changes the minimum required password length to 12 in alignment with https://github.com/OWASP/ASVS/blob/master/4.0/en/0x11-V2-Authentication.md?plain=1#L43

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.

taylordowns2000 added a commit to OpenFn/docs that referenced this pull request Sep 18, 2024
Only for merging after OpenFn/lightning#2507 is on demo.openfn.org
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (6a56fc3) to head (18ef06b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         314      314           
  Lines       10875    10875           
=======================================
  Hits         9836     9836           
  Misses       1039     1039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit 23ff7f5 into main Sep 20, 2024
8 checks passed
@stuartc stuartc deleted the asvs-password-length branch September 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants