Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust stub #2687

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Adjust stub #2687

merged 1 commit into from
Dec 4, 2024

Conversation

rorymckinley
Copy link
Collaborator

@rorymckinley rorymckinley commented Nov 18, 2024

Description

This adjusts a stub that runs into what appear to be Mox limitations when stubbing calls where the module is not explicitly specified.

Closes #2686

Validation steps

  1. (How can a reviewer validate your work?)

No production code was harmed in the making of this PR :).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@rorymckinley rorymckinley self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (bca6701) to head (791ce15).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
+ Coverage   91.06%   91.09%   +0.02%     
==========================================
  Files         332      332              
  Lines       11629    11629              
==========================================
+ Hits        10590    10593       +3     
+ Misses       1039     1036       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rorymckinley rorymckinley requested a review from stuartc November 19, 2024 09:41
@stuartc stuartc merged commit 4cb69b8 into main Dec 4, 2024
8 checks passed
@stuartc stuartc deleted the 2686-tweak-stub branch December 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update tests that slipped through CI
2 participants