Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.15 #997

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Elixir 1.15 #997

merged 4 commits into from
Jul 31, 2023

Conversation

taylordowns2000
Copy link
Member

@taylordowns2000 taylordowns2000 commented Jul 28, 2023

This should fix that annoying Elixir-LS issue. (I've tried to trigger it a few times and so far so good.) Also, everything appears to work well on Elixir 1.15 and Erlang 26.

Update

  1. Elixir 1.15 jeremyjh/dialyxir#512 - when this is merged we'll get cleaner dialyzer output
  2. there are a handful of dialyzer errors - should we be worried about these?

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@taylordowns2000 taylordowns2000 marked this pull request as ready for review July 28, 2023 16:12
@taylordowns2000 taylordowns2000 marked this pull request as draft July 29, 2023 07:18
@taylordowns2000 taylordowns2000 marked this pull request as ready for review July 29, 2023 07:20
Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @taylordowns2000, re: the dialyzer warnings - they are fine for now (i.e. not functional difference) but we will have to address them. I gave it a quick go around, and it looks like %Task{ref: reference()} is marked as opaque now, which means we're not supposed to directly reference it.

The two modules that have this issue will need to be refactored a bit, will have to schedule that in.

@@ -34,7 +34,7 @@ jobs:
elixir_version:
description: Elixir version
type: string
default: "1.14.1"
default: "1.15.4-otp-25"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartc stuartc merged commit e4941f5 into main Jul 31, 2023
@stuartc stuartc deleted the elixir-1.15 branch July 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants