Skip to content

Commit

Permalink
[WIP] Fixes for feedback (#62)
Browse files Browse the repository at this point in the history
* correct cli tutorial name of directory

* ligand-network-viewer => view-ligand-network
  • Loading branch information
dwhswenson authored May 13, 2023
1 parent be7d4f8 commit d16b4ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
10 changes: 5 additions & 5 deletions rbfe_tutorial/cli_tutorial.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ network_setup
```

The `ligand_network.graphml` file describes the atom mappings between the
ligands. We can visualize it with the `openfe ligand-network-viewer` command:
ligands. We can visualize it with the `openfe view-ligand-network` command:

```bash
openfe ligand-network-viewer network_setup/ligand_network.graphml
Expand Down Expand Up @@ -104,8 +104,8 @@ run each simulation on your local machine with something like:

```bash
# this will take a very long time! don't actually do it!
for file in setup/transformations/*.json; do
relpath=${file:22} # strip off "setup/transformations/"
for file in network_setup/transformations/*.json; do
relpath=${file:30} # strip off "network_setup/transformations/"
dirpath=${relpath%.*} # strip off final ".json"
openfe quickrun $file -o results/$relpath -d results/$dirpath
done
Expand All @@ -121,9 +121,9 @@ and submit a job script for the simplest SLURM use case:

```bash
for file in setup/transformations/*.json; do
relpath=${file:22} # strip off "setup/transformations/"
relpath=${file:30} # strip off "network_setup/transformations/"
dirpath=${relpath%.*} # strip off final ".json"
jobpath="setup/transformations/${dirpath}.job"
jobpath="network_setup/transformations/${dirpath}.job"
cmd="openfe quickrun $file -o results/$relpath -d results/$dirpath"
echo -e "#!/usr/bin/env bash\n${cmd}" > $jobpath
sbatch $jobpath
Expand Down
4 changes: 1 addition & 3 deletions rbfe_tutorial/python_tutorial.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,7 @@
"\n",
"That information in included in a `Transformation`. Each of these transformations corresponds to a single leg of the simulation campaign, so for each edge in the `LigandNetwork`, we will create two `Transformation`s: one for vacuum and one for solvent.\n",
"\n",
"In practice, this will be done for each edge of the `LigandNetwork` in a loop, but for illustrative purposes we'll dive into the details of creating a single transformation. In particular, we'll create the solvent leg for the pair of molecules we selecting for the mapping above.\n",
"\n",
"TODO: SWITCH TO PROTEIN COMPLEX LEG"
"In practice, this will be done for each edge of the `LigandNetwork` in a loop, but for illustrative purposes we'll dive into the details of creating a single transformation. In particular, we'll create the solvent leg for the pair of molecules we selecting for the mapping above."
]
},
{
Expand Down

0 comments on commit d16b4ef

Please sign in to comment.