Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Overview of gufe #200

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Docs: Overview of gufe #200

merged 1 commit into from
Jun 15, 2023

Conversation

dwhswenson
Copy link
Member

The idea here is to give the very-big-picture view of what gufe involves. As docs for each of the headers in this get filled out, these headers should link to that.

Audience here is incoming devs, to help orient them to the project.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9f76f3) 99.09% compared to head (1fd8f70) 99.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          36       36           
  Lines        1760     1760           
=======================================
  Hits         1744     1744           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +66 to +73
Strategies
----------

Strategies have yet to be implemented, but the GUFE design leaves a place
for an object that, at the scale of an alchemical network, can dynamically
decide where to focus more simulation effort based on the results that have
been received so far. This will be useful for adaptive approaches to
sampling a network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe leave this out if it doesn't exist? Or maybe have a separate page of planned future scope?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled with the same. We need to document this concept somewhere, because it informs other architectural decisions. I thought that putting a very brief paragraph here was the least-bad option, but I'd be open to other options. But I like this page being a 1-page overview of the whole architecture, as a place for people to start.

core chemistry and alchemistry of a free energy pipeline, including
molecules, chemical systems, and alchemical transformations. This provides a
shared language that different tools use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth having a brief section on Components here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the next page in the guide is going to be a discussion of the Components approach (we already have a placeholder for it). My goal for this page is to be an extended table of contents for the rest of the "guide" section; details will come later.

@richardjgowers richardjgowers merged commit 7cd4f3f into main Jun 15, 2023
@richardjgowers richardjgowers deleted the dev-docs branch June 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants