Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the gufe key for DAG name, not hash #61

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

dwhswenson
Copy link
Member

I think this is what was actually desired, and using hash was just an older idea that didn't get caught in review.

(1-line change)

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 96.74% // Head: 96.74% // No change to project coverage 👍

Coverage data is based on head (5ceb43d) compared to base (69ad4d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files          26       26           
  Lines        1261     1261           
=======================================
  Hits         1220     1220           
  Misses         41       41           
Impacted Files Coverage Δ
gufe/transformations/transformation.py 87.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richardjgowers richardjgowers merged commit 01dcce2 into main Sep 23, 2022
@richardjgowers richardjgowers deleted the transformation-name-gufe-key branch September 23, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants