-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding hybridization change filter #35
Conversation
Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-30 18:39:36 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 96.16% 96.21% +0.04%
==========================================
Files 13 13
Lines 574 581 +7
==========================================
+ Hits 552 559 +7
Misses 22 22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, would it also make sense to have a cyclohexane to benzene test too?
@richardjgowers yes that is a very important change filter (benzene to cyclohex). But we would need to check the all ring atoms, I think. Therefore this would be a ring-change filter, similar to your whole ring filter. |
This PR adds a filter for hybridization_changes of atoms, disallowing them.