Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hybridization change filter #35

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Jan 29, 2024

This PR adds a filter for hybridization_changes of atoms, disallowing them.

  • general hybridization changes

@pep8speaks
Copy link

pep8speaks commented Jan 29, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 57:78: W291 trailing whitespace
Line 70:1: W293 blank line contains whitespace
Line 70:1: W391 blank line at end of file

Line 45:46: W291 trailing whitespace

Comment last updated at 2024-01-30 18:39:36 UTC

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9757264) 96.16% compared to head (3a4e81b) 96.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   96.16%   96.21%   +0.04%     
==========================================
  Files          13       13              
  Lines         574      581       +7     
==========================================
+ Hits          552      559       +7     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiesBen RiesBen mentioned this pull request Jan 29, 2024
2 tasks
Copy link
Contributor

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good, would it also make sense to have a cyclohexane to benzene test too?

src/kartograf/tests/test_element_filters.py Outdated Show resolved Hide resolved
src/kartograf/filters/element_change.py Outdated Show resolved Hide resolved
@RiesBen
Copy link
Contributor Author

RiesBen commented Jan 30, 2024

@richardjgowers yes that is a very important change filter (benzene to cyclohex). But we would need to check the all ring atoms, I think. Therefore this would be a ring-change filter, similar to your whole ring filter.

@richardjgowers richardjgowers merged commit e4b4f7a into main Jan 30, 2024
7 checks passed
@richardjgowers richardjgowers deleted the add_additional_filters branch January 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants