Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring hybridization filter #36

Merged
merged 13 commits into from
Mar 29, 2024
Merged

ring hybridization filter #36

merged 13 commits into from
Mar 29, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Feb 2, 2024

This branch adds a ring hybridization change filter. (like discussed here: #30)

@RiesBen RiesBen added the enhancement New feature or request label Feb 2, 2024
@pep8speaks
Copy link

pep8speaks commented Feb 2, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 121:80: E501 line too long (92 > 79 characters)
Line 122:80: E501 line too long (80 > 79 characters)
Line 123:80: E501 line too long (84 > 79 characters)
Line 144:80: E501 line too long (94 > 79 characters)

Line 104:80: E501 line too long (80 > 79 characters)
Line 114:80: E501 line too long (87 > 79 characters)
Line 117:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-03-28 23:48:27 UTC

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (f371334) to head (875359c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   96.21%   96.35%   +0.14%     
==========================================
  Files          13       13              
  Lines         581      604      +23     
==========================================
+ Hits          559      582      +23     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/kartograf/filters/ring_changes.py Outdated Show resolved Hide resolved
src/kartograf/filters/ring_changes.py Outdated Show resolved Hide resolved
src/kartograf/filters/ring_changes.py Outdated Show resolved Hide resolved
src/kartograf/filters/ring_changes.py Outdated Show resolved Hide resolved
src/kartograf/filters/ring_changes.py Outdated Show resolved Hide resolved
src/kartograf/tests/test_ring_filters.py Outdated Show resolved Hide resolved
src/kartograf/tests/test_ring_filters.py Show resolved Hide resolved
src/kartograf/tests/test_ring_filters.py Outdated Show resolved Hide resolved
@RiesBen RiesBen merged commit cae6fc9 into main Mar 29, 2024
7 checks passed
@RiesBen RiesBen deleted the ringHybridFilter branch March 29, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants