Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update element_change.py #39

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update element_change.py #39

merged 1 commit into from
Apr 10, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Mar 27, 2024

fix for issue #37

This PR should fix the filter_atoms_h_only_h_mapped bug found by @okbckim

@RiesBen RiesBen added the bug Something isn't working label Mar 27, 2024
@RiesBen RiesBen requested a review from richardjgowers March 27, 2024 09:25
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (f371334) to head (0ff2881).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          13       13           
  Lines         581      581           
=======================================
  Hits          559      559           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiesBen RiesBen merged commit 8ef8f88 into main Apr 10, 2024
7 checks passed
@RiesBen RiesBen deleted the bug-fix-in-filter-atoms_h branch October 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant