89 add tests to cover missing scorer behavior #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 86.81% 86.93% +0.12%
==========================================
Files 49 49
Lines 1577 1577
==========================================
+ Hits 1369 1371 +2
+ Misses 208 206 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
IAlibay
approved these changes
Nov 19, 2024
|
|
||
| @pytest.mark.parametrize("n_process", [1, 2]) | ||
| @pytest.mark.parametrize("with_progress", [True, False]) | ||
| @pytest.mark.parametrize("with_scorer", [True, False]) |
There was a problem hiding this comment.
Just wanted to check - this just being removed because the test fixture just wasn't being used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the job done to address coverage concerns in #84.
I'd also like to look into the bare
excepterror catching. We should be more specific about what errors are okay, and which we want to let be thrown.