Mat 287 multilibalise lapack #2
Conversation
…est input wrt instruction set so that windows doesn't get file lock errors
| # install(FILES | ||
| # ${CMAKE_CURRENT_BINARY_DIR}/blas.pc | ||
| # DESTINATION ${PKG_CONFIG_DIR} | ||
| # ) |
There was a problem hiding this comment.
We could delete this since we never install anything we build.
There was a problem hiding this comment.
I do. This is how the -DconfigFile thing works when testing stuff that hasn't quite made it into the autoextractor thing. Going to leave it in if that's ok?
There was a problem hiding this comment.
Noted this is commented, will remove. Added MAT-291 to create multilib installer.
|
This looks good, and I'd be happy to merge it. I have one question: MultiLib and MultiBin.cmake both seem to do the same thing, except one calls add_library and the other add_executable - is this correct? If it is correct, maybe they be merged into a single module with common functionality? |
|
Added MultiInstructionTarget.cmake which combines the two multi* modules. Factored out CheckCPUID into a module and added a cached var so it only runs once. Fixed up other bits suggested in 4dba77a . |
|
Thanks for patching cache correctly. If happy, I'm happy. Merge on BB pass :) |
|
Latest buildbot pass: http://devmaths-lx-1:8011/builders/OG-Lapack-testing/builds/13 |
This attempts to get lapack building with multiple instruction set support. It also gets the test suite to report more cleanly. MAT-289 outlines outstanding testing bug.
BB Pass: http://devmaths-lx-1:8011/builders/OG-Lapack-testing/builds/11