Improve webgl lineFeature and polygonFeature. #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
webgl-line-improvements
branch
2 times, most recently
from
3711dbb
to
6453af8
Compare
manthey
force-pushed
the
webgl-line-improvements
branch
from
6453af8
to
b3699a4
Compare
aashish24
reviewed
Sep 19, 2019
| orderLen = order.length, | ||
| posBuf, prevBuf, nextBuf, farBuf, flagsBuf, indicesBuf, | ||
| posBuf, prevBuf, nextBuf, farBuf, flagsBuf, |
There was a problem hiding this comment.
@manthey would it be possible to add some note here on each buffer type specifically the flags buff?
aashish24
reviewed
Sep 19, 2019
| @@ -25,8 +25,10 @@ var flagsLineJoin = { // uses 3 bits with flagsLineCap | |||
| round: 6, | |||
| 'miter-clip': 7 | |||
| }; | |||
| var flagsNearLineShift = 2, flagsFarLineShift = 5; | |||
| var flagsNearOffsetShift = 8; // uses 11 bits | |||
| var flagsNearLineShift = 2, flagsNearLineMult = 1 << flagsNearLineShift; | |||
There was a problem hiding this comment.
Same here, if we add some code comment on how these flags are used, it would be be easy to remember and understand the code
There was a problem hiding this comment.
@aashish24 I've added more to the comment above all of the flag definitions.
manthey
force-pushed
the
webgl-line-improvements
branch
from
b3699a4
to
7ce2a0c
Compare
manthey
force-pushed
the
webgl-line-improvements
branch
from
7ce2a0c
to
73d00ae
Compare
aashish24
approved these changes
Oct 4, 2019
manthey
force-pushed
the
webgl-line-improvements
branch
from
73d00ae
to
9564c45
Compare
Reduce memory transfer to the gpu when only styles have changed in lines or polygons. Rename some internal variables in the line feature to make it clearer. Use constants to avoid array lookups in a few spots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory transfer to the gpu when only styles have changed in lines or polygons.
Rename some internal variables in the line feature to make it clearer.
Use constants to avoid array lookups in a few spots.