feat: Add a cursor annotation mode. #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
cursor-annotation-mode
branch
2 times, most recently
from
a50ca92
to
b8288b5
Compare
See the annotation example for the utility of this mode.
manthey
force-pushed
the
cursor-annotation-mode
branch
from
b8288b5
to
99952f4
Compare
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the annotation example for the utility of this mode.
This becomes slow with polygons with a large number of edges (easy to create with circles). Most of the time is in the polybool library, some of which is in the conversion to and from their segments and much is in the actual math. Additionally, formatting the geojson once updated also takes significant time.
One improvement could be made by adding a rotated rectangle between drag points when using a brush. This would reduce jaggedness and reduce the number of edges. Otherwise, looking into faster conversion to and from the polybool library is probably where the easiest speed-ups will occur.