Move grunt build step to npm build #461
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that putting a
grunt
build step inpostinstall
is a bad idea as it causes all sorts of problems due to npm's dependency resolution rules. We should modify the release workflow to put the build step inprepublish
instead so that built files are added to the npm release.This is a temporary fix to allow other projects to depend on geojs without hitting build issues. These projects will need to execute
npm install; npm run build
manually to build the library.