Allow overriding the tilesAtZoom function. #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, it was assumed that there was 2^level tiles in each direction at each level. For non-square tile source (such as slide images), this is not the case. Unless (until?) the tilesLayer knows how many pixels of tiles are available for the maximum level, the `tilesAtZoom` function needs to change. This allows it to be specified as an option. This is related to issue #544, but does not complete that.
Current coverage is 70.66%@@ master #568 diff @@
========================================
Files 81 81
Lines 7039 7041 +2
Methods 0 0
Branches 0 0
========================================
+ Hits 4971 4975 +4
+ Misses 2068 2066 -2
Partials 0 0
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, it was assumed that there was 2^level tiles in each direction at each level. For non-square tile source (such as slide images), this is not the case. Unless (until?) the tilesLayer knows how many pixels of tiles are available for the maximum level, the
tilesAtZoomfunction needs to change. This allows it to be specified as an option.This is related to issue #544, but does not complete that.