Remove grunt #580
Merged
Remove grunt #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in version 1.17.4 that causes the fakeServer to break.
| @@ -0,0 +1,418 @@ | |||
| /* Jison generated parser */ | |||
There was a problem hiding this comment.
I don't think you meant to check in this file.
There was a problem hiding this comment.
I did actually. As it exists on npm, jsonlint won't work with webpack. The library is small, so I copied it here and removed the offending code.
Current coverage is 73.12%@@ master #580 diff @@
==========================================
Files 82 82
Lines 7216 7216
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 5276 5276
Misses 1940 1940
Partials 0 0
|
|
LGTM. |
|
Farewell to Grunt 👏 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly to remove grunt from the build process. As an alternative, a script builds all of the jade templates for the examples into html. Webpack is used to build all of the dependency into one main bundle that all of the examples use.
A few other changes are implemented here as well:
SELENIUM_TESTSby default because it is needed for downloading data for the examples. I would like to use an alternative mechanism for this, but I'll do that in a different PR.