Fix selection rectangle and add selection-based zoom #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the Quad feature instead of the Plane feature.
This resolves issue #346.
manthey
force-pushed
the
selection-based-zoom
branch
from
66414b5
to
cf12c17
Compare
Current coverage is 74.63%@@ master #582 diff @@
==========================================
Files 85 85
Lines 7375 7400 +25
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5460 5523 +63
+ Misses 1915 1877 -38
Partials 0 0
|
Merged
|
There is an issue when the selection rectangle straddles 180 degrees E or W. |
This avoids issues when the map wraps.
manthey
changed the title
|
@manthey I will review this one next as I believe the bug has been fixed?. |
|
@aashish24 Yes. Selection and zoom across wrapped maps is now fine. |
|
LGTM 👍 thanks. |
This was referenced Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the selection rectangle on rotated maps. Use the Quad feature instead of the Plane feature.
Add "rubberband" zoom in and zoom out. By default, this zoom in is performed with shift-left-mouse button, and zoom out with shift-right-mouse-button.
This resolves issues #548 and #346.
This depends on PR #581.