Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wms styling #595

Merged
merged 8 commits into from
Jul 14, 2016
Merged

Wms styling #595

merged 8 commits into from
Jul 14, 2016

Conversation

dorukozturk
Copy link

Added an example to style wms raster tiles on the fly via the sld file. We are including visualization specs to the url as a parameter called "SLD_BODY". The UI listens for any change on the forms and updates the map by doing the following steps:

  1. Delete the current layer
  2. Regenerate the URL using the new parameters
  3. Send a GET request with the new visualization parameters

@aashish24 @jbeezley @manthey

@codecov-io
Copy link

codecov-io commented Jun 28, 2016

Current coverage is 78.82%

Merging #595 into master will not change coverage

@@             master       #595   diff @@
==========================================
  Files            82         82          
  Lines          7354       7354          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5797       5797          
  Misses         1557       1557          
  Partials          0          0          

Powered by Codecov. Last updated by 6986a8d...be38ff4

@manthey
Copy link
Contributor

manthey commented Jul 5, 2016

I think all of our other example thumb.jpg files are 800x600 pixels in size, so for consistency, we probably want to make this one the same.

],
9: ['#ffffe5', '#f7fcb9', '#d9f0a3', '#addd8e', '#78c679',
'#41ab5d', '#238443', '#006837', '#004529'
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are limiting the color count to 8. Is there some virtue to keeping the entries for >= 9 in the colorbrewer object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually prefer installing this through npm anyway.

@dorukozturk
Copy link
Author

I think this is ready for a second review. @manthey @jbeezley

@jbeezley
Copy link
Contributor

It looks much better, thanks. One thing I'm noticing is that the overlay is misaligned a bit. It looks like it is shifted to the north a bit. The tiles are being placed correctly, so it is either a problem with the bounding box computation (in EPSG:3857 coordinates) or the geoserver is misinterpreting them. What's odd is that the other wms example is done the same way, but there doesn't seem to be a similar misalignment.

@dorukozturk
Copy link
Author

@jbeezley You are right. There was an error with the projection. I fixed it.

@jbeezley
Copy link
Contributor

LGTM

@jbeezley jbeezley merged commit d8f9bdc into master Jul 14, 2016
@jbeezley jbeezley deleted the wms-styling branch July 14, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants