Add closed flag to line features #602
Conversation
The last point in the line need not be duplicated. The closed flag will automatically join the first and last points. Polygons now always use closed lines. The picking example can take an optional parameter ?closed=true to show closed lines, allowing picking tests on the close segment.
BREAKING CHANGE: The pointSearch function returned different keys depending on whether data was present or not in both the pointFeature and the lineFeature. Specifically, when there is no data in a feature, or other pointSearch functions (in quad, polygon, and the base class feature), pointSearch returns {index: [...], found: [...]}. When data is present, the point and line features returned {index: [...], data: [...]}. This has been changed to always return {index: [...], found: [...]}.
Added unit tests for line features.
Current coverage is 81.54% (diff: 100%)@@ master #602 diff @@
==========================================
Files 82 82
Lines 7419 7436 +17
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5989 6064 +75
+ Misses 1430 1372 -58
Partials 0 0
|
| firstpos = pos; | ||
| } | ||
| } | ||
| if (lineItem.length > 2 && closedFunc(data[i], i)) { |
There was a problem hiding this comment.
Why passing two arguments to closedFunc?
There was a problem hiding this comment.
Our general method of getting style information from functions is to pass two parameters: the current data item and its index.
There was a problem hiding this comment.
For sub-components, like points within a line, the style information is obtained by calling a function with four parameters: the current sub-item (a vertex, for instance), the sub-item's index, the current item (the line), and the item index.
There was a problem hiding this comment.
Our general method of getting style information from functions is to pass two parameters: the current data item and its index.
Sure, makes sense.
|
Looking pretty good to me, just had one questions. Also, on returning data, was the data object pointed to the original data object? |
|
No. When we called pointSearch, the |
ah, yes, I see that now, the change is just a key change, the value remains the same. 👍 |
|
Lgtm +1 |
The closed flag will automatically join the first and last points. The last point in the line need not be duplicated.
Polygons now always use closed lines.
The picking example can take an optional parameter ?closed=true to show closed lines, allowing picking tests on the close segment.
BREAKING CHANGE: Fixed inconsistency in
pointSearch. ThepointSearchfunction returned different keys depending on whether data was present or not in both the point and line features. Specifically, when there is no data in a feature, or otherpointSearchfunctions (in quad, polygon, and the base class feature),pointSearchreturns {index: [...], found: [...]}. When data is present, the point and line features returned {index: [...], data: [...]}. This has been changed to always return {index: [...], found: [...]}.Added unit tests for line features.
Resolves issue #599.