Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how actions are specified and detected. #603

Merged
merged 10 commits into from
Aug 29, 2016

Commits on Jul 27, 2016

  1. Refactor how actions are specified and detected.

    This is primarily to make the code reusable in other modules.  This results in some improvements:
    * Modifier keys can be ignored.  For instance, ctrl-left drag defaults to rotation, shift must not be pressed, but the state of alt and meta is irrelevant.
    * You could add an action that requires two mouse buttons.
    
    This is a breaking change.
    manthey committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    2251d58 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2016

  1. Merge branch 'master' into refactor-interactor-actions

    Conflicts:
    	src/mapInteractor.js
    manthey committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    5acd17c View commit details
    Browse the repository at this point in the history
  2. Do less work on mouse moves.

    manthey committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    078fb6c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2016

  1. More refactoring of interactor actions.

    Trigger more events to allow other interactors more fine-grained control.  For actions with a selection rectangle, use a flag in the action definition rather than a test against the action name.  Return the action record from the eventMatch function.  Add convenience functions for adding and removing actions.
    manthey committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    abccfdf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef00faa View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2016

  1. Rename event to input in the actions.

    The term 'event' was overused.
    manthey committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    35b1442 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2016

  1. Add a set of defined constants for actions.

    As part of this, there doesn't need to be a one-to-one correspondence between actions and events.  Moreover, selection rectangle-based actions can trigger any event.
    manthey committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    1d400b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72a4fff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    474190e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. Configuration menu
    Copy the full SHA
    136e2d5 View commit details
    Browse the repository at this point in the history