Removed deprecated/unused files #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish24
force-pushed
the
remove_unused
branch
from
1aeef9f
to
df2c202
Compare
Current coverage is 88.00% (diff: 100%)@@ master #656 diff @@
==========================================
Files 87 84 -3
Lines 8591 8471 -120
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7465 7455 -10
+ Misses 1126 1016 -110
Partials 0 0
|
|
I think you meant to remove |
aashish24
force-pushed
the
remove_unused
branch
from
df2c202
to
43367bf
Compare
Yes, I missed that out in my commit. Should be fixed now. |
|
@jbeezley should I generate new geo.js? Or do we that at the point of release? |
|
That gets done at release. |
manthey
approved these changes
Dec 14, 2016
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the release 1.0 plan, removed unused / deprecated code.