Blog lines examples #662
Merged
Blog lines examples #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish24
reviewed
Jan 23, 2017
| @@ -3,7 +3,7 @@ extends ./common/templates/index.jade | |||
| mixin thumbnail(ex) | |||
| .col-md-4 | |||
| .thumbnail | |||
| a(href="#{ex.path}") | |||
| a(href="#{ex.path}/") | |||
There was a problem hiding this comment.
I may know the reason but curious on why we had to do this?
There was a problem hiding this comment.
On demo.kitware.com, we are proxying from a directory (demo.kitware.com/geojs/). The code in the node express server that redirects directories strips off the proxy location (e.g., demo.kitware.com/geojs/examples/lines => demo.kitware.com/examples/lines/). Rather than figure out how to better proxy node express, if we just ask for where we want to go to start with, it saves a redirect and goes to the right place.
There was a problem hiding this comment.
Okay, thanks thats what i thought
aashish24
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the hidden example used for the lines blog comparison grid.
Probably the most useful piece of this is the the ability to compare different versions of geojs and other libraries.