Convert all selenium tests to use xvfb. #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The d3 renderer was issuing an undefined event when it was resized. This has been corrected to issue the d3.rescale event. The tests in testing/test-cases/selenium-tests/featureVisible are already handled by tests/cases/feature.js, so they have been removed without conversion. Taking a screenshot of mixed d3 and vgl layers could erroneously place the d3 layers on top. This has been fixed.
|
There may be other files we can get rid of now that selenium is no longer in use. There are some files in the |
manthey
force-pushed
the
convert-selenium-tests
branch
from
82614a9
to
eedebd1
Compare
manthey
force-pushed
the
convert-selenium-tests
branch
from
eedebd1
to
5cbd243
Compare
onIdle should include these, too.
manthey
force-pushed
the
convert-selenium-tests
branch
from
4e04eba
to
abd908f
Compare
manthey
force-pushed
the
convert-selenium-tests
branch
2 times, most recently
from
879e7e3
to
cdcf47d
Compare
Try to handle slow tests better by waiting for more identifiable conditions.
manthey
force-pushed
the
convert-selenium-tests
branch
from
cdcf47d
to
a35aefc
Compare
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 90.75% 91.93% +1.17%
==========================================
Files 84 84
Lines 8736 8749 +13
==========================================
+ Hits 7928 8043 +115
+ Misses 808 706 -102
Continue to review full report at Codecov.
|
|
@aashish24 I'm sure some of these tests are still brittle, but I think this is ready for review. |
|
+2 |
This was referenced Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The d3 renderer was issuing an undefined event when it was resized. This has been corrected to issue the d3.rescale event.
The tests in testing/test-cases/selenium-tests/featureVisible are already handled by tests/cases/feature.js, so they have been removed without conversion.
Taking a screenshot of mixed d3 and vgl layers could erroneously place the d3 layers on top. This has been fixed.