Add unit tests for the point feature. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR illustrates why we want to have unit tests on everything -- I discovered a few bugs and inconsistencies while writing them that weren't exposed in our various test cases. |
Fixed some issues with the pointFeature: - Setting the position on construction resulted in different behavior than setting it afterwards. - Setting the clustering on construction allowed non-default values, but during the setter would only allow defaults. - If set, the clustering could not be changed except by unsetting it and resetting it. - The maximum radius of any point is used when deciding where to search for points, but it was potentially not calculated until after it was used. Made some improvements: - The position function wraps the position in another function to handle clustering. If the position is not a function, then only one function call is made rather than two. - Removed the unused internal _boundingBox function from the pointFeature. - Added some comments about when you would want to use a different primitiveShape with the gl point feature.
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 92.02% 93.89% +1.86%
==========================================
Files 84 84
Lines 8857 8856 -1
==========================================
+ Hits 8151 8315 +164
+ Misses 706 541 -165
Continue to review full report at Codecov.
|
jbeezley
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues with the pointFeature:
Made some improvements: