Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial infrastructure. #725

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Add tutorial infrastructure. #725

merged 3 commits into from
Aug 3, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Aug 1, 2017

This adds a method for creating tutorials. There is a basic tutorial which is mostly defined in a pug template. Code blocks are user-editable, and will update a live iframe with the results. The pug template can define tests for code blocks which are run as part of the test suite.

Fixed some inconsistent use of jQuery $.Deferred where sometimes we added the new operator before calling it, which is unnecessary.

This adds a method for creating tutorials.  There is a basic tutorial which is mostly defined in a pug template.  Code blocks are user-editable, and will update a live iframe with the results.  The pug template can define tests for code blocks which are run as part of the test suite.

Fixed some inconsistent use of jQuery $.Deferred where sometimes we added the `new` operator before calling it, which is unnecessary.
Simplify the required pug template a little more.
Don't mock webGL in the tests; it needs to be done in the inner iframe.

Allow passing through a crossDomain setting of null.

Simpler tutorial titles.

Order tutorials.
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 . I think we have covered some of the possible improvements for the future. Should we document them some where? For e.g. (accordion widget for css and html)

@aashish24
Copy link
Member

@matthewma7 would it be possible to update the io pages to include tutorials as well?

@manthey manthey merged commit f302872 into master Aug 3, 2017
@manthey manthey deleted the tutorial branch August 3, 2017 12:06
@matthewma7
Copy link

@aashish24 Yes, I'll try to integrated in the the new site. @manthey just a heads up, I may need some input from you in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants