Ensure that GL polygons are built once before their strokes. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we build a webgl polygon we attach two vgl actors, one for the polygon and one for the stroke (lines). Whichever actor gets attached first is drawn first. We always want to draw the fill before the stroke, but for efficiency it can be deferred an animation frame when there are updates. The first time this is rendered, don't allow such a delay. This change ensures that the fill actor is added before the stroke actor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build a webgl polygon we attach two vgl actors, one for the polygon and one for the stroke (lines). Whichever actor gets attached first is drawn first. We always want to draw the fill before the stroke, but for efficiency it can be deferred an animation frame when there are updates. The first time this is rendered, don't allow such a delay. This change ensures that the fill actor is added before the stroke actor.