Make zoom via wheel more responsive at the ends of the zoom range. #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
more-responsive-zoom-wheel
branch
2 times, most recently
from
85919e1
to
5156d34
Compare
aashish24
approved these changes
May 29, 2019
manthey
force-pushed
the
more-responsive-zoom-wheel
branch
from
5156d34
to
534e183
Compare
Prior to this, zooming via the wheel until the map was fully zoomed in or zoomed out and then reversing the wheel could have a substantial lag before the zoom would reverse. While some debouncing is fine, this sometimes felt unresponsive. This ignores wheel events once the end of the range is reached rather than adding more time to the transition.
manthey
force-pushed
the
more-responsive-zoom-wheel
branch
from
534e183
to
8805e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, zooming via the wheel until the map was fully zoomed in or zoomed out and then reversing the wheel could have a substantial lag before the zoom would reverse. While some debouncing is fine, this sometimes felt unresponsive. This ignores wheel events once the end of the range is reached rather than adding more time to the transition.