Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/code cleanup #41

Merged
merged 16 commits into from
Nov 22, 2023
Merged

Dev/code cleanup #41

merged 16 commits into from
Nov 22, 2023

Conversation

buldo
Copy link

@buldo buldo commented Nov 17, 2023

No description provided.

@buldo buldo self-assigned this Nov 17, 2023
@buldo buldo requested a review from Consti10 November 17, 2023 13:16
@Consti10
Copy link

looks really good to me, only a few things:

  1. encryption - folder typo
  2. headers with a corresponding .cpp file should be named .h, only header only files should be named .hpp

@buldo
Copy link
Author

buldo commented Nov 20, 2023

@Consti10 fixed

@Consti10 Consti10 merged commit 2762d89 into master Nov 22, 2023
@Consti10 Consti10 deleted the dev/code_cleanup branch March 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Consti10 Consti10 Awaiting requested review from Consti10

Assignees

@buldo buldo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buldo @Consti10