Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #42

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Small refactoring #42

merged 5 commits into from
Jan 5, 2024

Conversation

buldo
Copy link

@buldo buldo commented Nov 27, 2023

Made code a bit easy to understand:

  • Big processing method splitted
  • Removed decryptor global state(because this state make sense only in tests)

@buldo buldo self-assigned this Nov 27, 2023
@buldo buldo requested a review from Consti10 November 27, 2023 22:16
@Consti10
Copy link

Consti10 commented Jan 5, 2024

In general, I like all those changes, the only issue i see are the changes to the encryption - while it makes sense on a first glance to seperate authenticate and decrypt and re-use authenticate in decrypt, i am not sure if

  1. that 'works' since for the decrypt path, libsodium provides a method that authenticates and decrypts in one go
  2. it migh reduce performance, since we (unneccessarily) call authenticate first, then authenticate an decrypt again

@Consti10
Copy link

Consti10 commented Jan 5, 2024

actually, not sure if what i wrote above is true ;) got a bit confused looking at the changes in git ;)

@Consti10 Consti10 merged commit 9d037db into master Jan 5, 2024
@Consti10 Consti10 deleted the small-refactoring branch March 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants