Skip to content

Comments

chore: Rename code-review.md to custom-codereview-guide.md#12922

Closed
xingyaoww wants to merge 1 commit intomainfrom
rename-codereview-skill
Closed

chore: Rename code-review.md to custom-codereview-guide.md#12922
xingyaoww wants to merge 1 commit intomainfrom
rename-codereview-skill

Conversation

@xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Feb 18, 2026

Summary

Rename the repo-specific code review skill to use a unique name that won't conflict with the public code-review skill.

Changes

  • Renamed skills/code-review.mdskills/custom-codereview-guide.md
  • Added name: custom-codereview-guide field to the frontmatter

Why

With a skill named code-review, it would completely override the default public code-review skill from OpenHands/extensions.

By using a unique name (custom-codereview-guide) with the same trigger (/codereview), both skills will now be activated:

  1. The default public code review guidelines
  2. The repo-specific guidelines

This gives reviewers the benefit of both general best practices AND repo-specific rules.

Related

@xingyaoww can click here to continue refining the PR


To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.openhands.dev/openhands/runtime:9f1dc33-nikolaik   --name openhands-app-9f1dc33   docker.openhands.dev/openhands/openhands:9f1dc33

Rename the repo-specific code review skill to use a unique name that
won't conflict with the public code-review skill. This allows both
the default public code review guidelines AND the repo-specific
guidelines to be triggered by /codereview.

Co-authored-by: openhands <openhands@all-hands.dev>
@xingyaoww xingyaoww marked this pull request as ready for review February 18, 2026 19:01
@xingyaoww xingyaoww enabled auto-merge (squash) February 18, 2026 19:02
@xingyaoww xingyaoww disabled auto-merge February 18, 2026 19:02
@xingyaoww xingyaoww closed this Feb 18, 2026
@github-actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes correctly add frontmatter to prevent name conflicts. However, the description may be misleading regarding whether this is a repo-specific or public skill.

@@ -1,4 +1,6 @@
---
name: custom-codereview-guide
description: Repo-specific code review guidelines for OpenHands/OpenHands. Provides additional review rules alongside the default code review skill.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The description says "Repo-specific code review guidelines for OpenHands/OpenHands," but this file is located in skills/ which is the public/shareable skills directory (available to all OpenHands users).

According to the skills/README.md, repository-specific skills should be in .openhands/skills/ or .openhands/microagents/.

Options:

  1. If this is meant to be public/shareable: Update the description to something like "Code review guidelines for OpenHands projects" (remove "repo-specific")
  2. If this is meant to be repository-specific: Move it to .openhands/skills/custom-codereview-guide.md

The skill content itself is generic enough to be public, so option 1 seems more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants