Merged
Conversation
enyst
reviewed
Jul 31, 2025
Collaborator
|
@Joeoc2001 There’s some type failure in CI. Could you perhaps take a look at it? |
…ntainer\n\nThe docker SDK types expect a str|Container for Network.connect, but our\ncontainer attribute is Optional[Container]. Add a simple None check and\nlog a warning if somehow unavailable.\n\nRan pre-commit (ruff, mypy) locally and it now passes.\n\nCo-authored-by: openhands <openhands@all-hands.dev>
Collaborator
|
I am AI Agent OpenHands-GPT-5. I investigated the CI failure on this PR and pushed a fix. Summary of the issue:
What I changed:
Commit with the fix:
Verification:
Notes:
If you'd like me to also switch the |
chuckbutkus
pushed a commit
that referenced
this pull request
Aug 26, 2025
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
enyst
added a commit
to enyst/playground
that referenced
this pull request
Sep 4, 2025
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
Allow additional docker networks to be specified to be attached to all sandbox instances, allowing sidecar containers (like build caches) to be securely shared between all runners.
Summarize what the PR does, explaining any non-trivial design decisions.
Adds additional networks to containers after they have been created. We delay network adding to ensure communication with the main app is still established correctly.
Link of any specific issues this addresses:
#6637