chroe(vscode): Refresh vscode integration lockfile#9965
Conversation
enyst
left a comment
There was a problem hiding this comment.
Oh, thank you!
Hmm, will need to think of something to keep it close to FE 🤔
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like
Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
|
@OpenHands please investigate and fix the failing actions on PR #9965 |
|
I'm on it! amanape can track my progress at all-hands.dev |
The lockfile refresh updated glob to v11.0.3, which has a different API. Updated the test suite to use the new glob import syntax and async/await pattern instead of the deprecated callback pattern.
|
Perfect! Let me now check if the request has been completely addressed: Request Analysis Checklist:✅ 1. Investigated failing actions on PR #9965
✅ 2. Root cause analysis
✅ 3. Fixed the failing action
✅ 4. Verified the fix
✅ 5. Changes are concise
Final SummaryI successfully investigated and fixed the failing actions on PR #9965. The issue was in the VSCode Extension CI workflow, specifically in the "Validate .vsix file" step. Root Cause: The PR refreshed the VSCode integration lockfile, which updated the Solution: I updated
Verification: The fix has been tested locally - the VSCode extension now builds successfully, generates a valid .vsix file, and passes all linting checks. The changes have been committed and pushed to the PR branch, triggering new workflow runs that should now pass. The failing action has been resolved, and the PR should now have all checks passing. |
|
A quick test, just that it installs and still does one of the commands, e.g. a menu command with selected text, will be great! |
|
PR Review After (PR Branch): Code is updated to use modern ES6 import syntax (import { glob } from "glob") and async/await pattern, but encounters TypeScript compilation errors despite using the correct glob v11 API syntax. TypeScript Errors: Conclusion: |
|
I think I saw in the lockfile that it uses some sub-packages like glob/types from 8.x version, and glob from 11.x version. That might explain it! I’m on an iPad in the forest (literally), maybe OH can help us here until I get back? 😅 |
🔧 VSCode Extension Built Successfully!The VSCode extension has been built and is ready for testing. 📦 Download: openhands-vscode-0.0.1.vsix (23 KB) 🚀 To install:
✅ Tested with: Node.js 22 Built from commit 3335792 |
|
@Abubakar-01 Thank you! I now downloaded the .vsix, cleaned up the older install, installed from vsix, then tried the context menu "OpenHands -> start with selected text" and "with file" and it worked. If it doesn't, could you please tell what exactly you do that fails? |
|
@enyst Just tried again, It is working for me aswell! |
|
Thank you! |
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
End-user friendly description of the problem this fixes or functionality this introduces.
Patches critical vulnerability
Summarize what the PR does, explaining any non-trivial design decisions.
Link of any specific issues this addresses:
To run this PR locally, use the following command:
GUI with Docker:
CLI with uvx: