docs: Update code review documentation with PR review workflow#302
docs: Update code review documentation with PR review workflow#302
Conversation
This is an initial layout that roughly mimics Devin docs. It attempts to separate Documentation and Use Cases.
- incident-triage.mdx: Add content based on Datadog debugging blog post - Features automated error analysis with OpenHands SDK - Includes GitHub Actions workflow for Datadog integration - Links to blog: https://openhands.dev/blog/debugging-production-issues-with-ai-agents-automating-datadog-error-analysis - cobol-modernization.mdx: Add content based on COBOL-to-Java refactoring blog post - Features iterative refinement approach with multiple agents - Includes code transformation examples (COBOL to Java) - Links to blog: https://openhands.dev/blog/20251218-cobol-to-java-refactoring - vulnerability-remediation.mdx: Add content based on vulnerability fixer documentation - Explains automated vulnerability remediation with AI agents - Links to example implementation at github.com/OpenHands/vulnerability-fixer - Covers integration with security scanners (Snyk, Dependabot, CodeQL) - dependency-upgrades.mdx: Remove redundant security scanning section - Links to Vulnerability Remediation page for security-related upgrades - Focuses on general dependency upgrade workflows Co-authored-by: openhands <openhands@all-hands.dev>
- Rename from 'TODO-Tutorial Library' to 'Tutorial Library' - Remove 'Getting Started with Tutorials' section - Add Note linking to Use Cases section for in-depth guidance - Add Code Review cross-references: - Link to Code Review Use Case page - Link to PR Review SDK Guide (sdk/guides/github-workflows/pr-review) - Add Bug Fixing cross-reference to Incident Triage Use Case Co-authored-by: openhands <openhands@all-hands.dev>
Replace tabs-based layout with a card-based design: - OpenHands Cloud (recommended) - links to https://app.all-hands.dev - Local GUI - links to /openhands/usage/run-openhands/local-setup - Terminal / CLI - links to /openhands/usage/cli/installation Each card includes relevant icons and bullet points highlighting key features. Co-authored-by: openhands <openhands@all-hands.dev>
- Rewrite code-review.mdx to document the automated PR review workflow - Explain how the workflow uses the Software Agent SDK with /codereview and /github-pr-review skills - Add Quick Start guide with step-by-step setup instructions - Document customization options including repo-specific review guidelines - Add security considerations and troubleshooting sections - Remove TODO- prefix from title Closes #297
|
@OpenHands please review the diff of this PR, and this PR: OpenHands/software-agent-sdk#1927 Now the SDK supports the new composed github action, can you update the documentation we add in this PR accordingly? |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
Update the code review documentation to reflect the new composite GitHub Action from software-agent-sdk PR #1927. The changes include: - Simplified Quick Start workflow using the composite action - Added new 'Composite Action' section with action inputs table - Updated Customization section to show input-based configuration - Removed manual setup steps (Python, uv, dependencies) that are now handled by the composite action Co-authored-by: openhands <openhands@all-hands.dev>
|
I've updated the code review documentation to reflect the new composite GitHub Action from software-agent-sdk PR #1927. The changes have been pushed to the Summary of ChangesFile modified: Key Updates:
The documentation is now much simpler for users to follow while still providing all the customization options through the action inputs. |
|
@OpenHands please fix the failing actions on PR #302 at branch |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
|
I've fixed the failing GitHub Actions on PR #302 by removing a broken link. Summary of ChangesFile modified: Issue: The "Check Broken Links" GitHub Action was failing because the file contained a link to Fix: Removed the broken link from the "Related Resources" section. The link was: The remaining related resources (Vulnerability Remediation and Prompting Best Practices) are still present and link to valid pages. Verification: Ran Commit: The changes have been pushed to the |
|
@OpenHands pls bring changes introduced in #306 to this PR |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
|
I've successfully brought the changes from PR #306 to this PR. The changes have been pushed to the Summary of ChangesFile modified: Key Updates from PR #306:
The changes are now live on PR #302. |
224c15a to
0717119
Compare
0717119 to
b76480e
Compare
…site action - Add 'Customizable' feature to Features section - Add new 'Customizing the Code Review' section with: - How custom skills work - Example custom code review skill - Benefits of custom skills - Update Reference Workflow to use simplified composite action - Add Action Inputs table documenting all available inputs - Add link to Composite Action in Related Files Co-authored-by: openhands <openhands@all-hands.dev>
…de-review.mdx - Add link to Composite Action in Related Resources section - Add reference to software-agent-sdk's code-review skill as example Co-authored-by: openhands <openhands@all-hands.dev>
- Add links to /codereview skill in OpenHands/skills repo - Add links to /codereview-roasted skill in OpenHands/skills repo - Add links to /github-pr-review skill in OpenHands/skills repo Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
- Remove generic 'What Gets Reviewed' section with tabs - Replace 'Example Review Output' with table of real PR examples from software-agent-sdk - Link to PRs #1927, #1916, #1904, #1889 showing different review styles Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
- Add 'API Key Protection' subsection explaining the potential risk - Document how SDK secrets mitigate the risk - Add best practices: review PRs first, use separate API keys, monitor usage - Link to SDK secrets documentation Co-authored-by: openhands <openhands@all-hands.dev>
- Summarize pull_request_target usage in one sentence - Keep warning about API key exfiltration risk concise - Remove prescriptive best practices list Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
enyst
left a comment
There was a problem hiding this comment.
Was this intended, to be only on Joe's branch?
Of course we can move forward anyway, just wondering since this is probably compatible with main as far as I can tell
|
@enyst yep! looks like we can merge to main |
|
My bad :( Looks like this PR also included a bunch of changes from Joe's PR that's probably not yet ready -- trying to revert unnecessary ones in #311 |
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
… workflow" (#311) * Revert "docs: Update code review documentation with PR review workflow (#302)" This reverts commit e557ece. * Keep pr-review.mdx changes from PR #302 Co-authored-by: openhands <openhands@all-hands.dev> * Keep code-review.mdx changes from PR #302 Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
Summary of changes
This PR completely rewrites the code review documentation page (
openhands/usage/use-cases/code-review.mdx) to document the automated PR review workflow powered by the OpenHands Software Agent SDK.Changes
High-Level Overview
/codereview(or/codereview-roasted) for code analysis and/github-pr-reviewfor posting inline commentsHow to Use
review-thislabel and requestingopenhands-agentas reviewerCustomization
.openhands/skills/code-review.mdwith/codereviewtriggerAdditional Sections
Closes #297
@xingyaoww can click here to continue refining the PR