Remove push_to_index option from run-eval.yml workflow#1750
Remove push_to_index option from run-eval.yml workflow#1750juanmichelini merged 1 commit intomainfrom
Conversation
Remove the 'Push results to openhands-index-results' option as it is being removed from downstream actions. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Code Review Summary
✅ Overall Assessment: The PR cleanly and completely removes all references to push_to_index from the workflow. The changes are syntactically correct.
What Was Verified
✅ Completeness: All four references removed:
- Input parameter definition (lines 73-77)
- Environment variable assignment (line 243)
- jq argument (line 261)
- JSON payload field (line 263)
✅ Syntax Validation:
- YAML syntax is valid
- jq command produces correct JSON output (tested locally)
- No trailing commas or structural issues
✅ No Orphaned References: Searched the entire codebase - no other files reference push_to_index
Minor Observations
🟡 Line Length: The jq command on line 258 is 450 characters long, which exceeds typical style guidelines. However, this is a pre-existing issue that was actually improved by this PR (reduced from ~478 characters). Consider splitting this into multiple lines in a future refactoring for better readability.
🟢 Downstream Coordination: The PR description states that push_to_index "is being removed from downstream actions". Please confirm that the downstream workflow in OpenHands/evaluation repo (specifically eval-job.yml) has been updated accordingly to prevent integration issues.
Recommendation
The changes are technically sound and ready to merge once downstream coordination is confirmed.
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Summary
Remove the
push_to_indexoption from therun-eval.ymlworkflow as it is being removed from downstream actions.Fixes #1749
Changes
push_to_indexinput parameter definition from workflow_dispatch inputsPUSH_TO_INDEXenvironment variable from the dispatch evaluation workflow steppush_to_indexargument from the jq command that builds the payloadpush_to_indexfield from the JSON payload sent to the evaluation workflowChecklist
@juanmichelini can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:2741856-pythonRun
All tags pushed for this build
About Multi-Architecture Support
2741856-python) is a multi-arch manifest supporting both amd64 and arm642741856-python-amd64) are also available if needed