Enable Laminar trajectory uploads in PR review workflow#1947
Enable Laminar trajectory uploads in PR review workflow#1947
Conversation
Map LAMINAR_ACTIONS_API_KEY secret to LMNR_PROJECT_API_KEY environment variable which is expected by the software-agent-sdk for Laminar observability integration. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Clean and straightforward change. The addition is minimal, well-commented, and follows the existing pattern. One minor suggestion about documentation.
|
@OpenHands please merge from main and resolve conflicts |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
Resolved conflicts in pr-review-by-openhands.yml by: - Keeping the simplified action-based approach from main - Adding lmnr-project-api-key input to the pr-review action - Passing LAMINAR_ACTIONS_API_KEY secret to enable trajectory uploads Co-authored-by: openhands <openhands@all-hands.dev>
|
Successfully merged main into the Summary of ChangesThe conflict in
The PR now properly enables Laminar observability while using the updated action-based workflow structure from main. |
|
@OpenHands check the changes made to the PR review process here: #1927 We'll want to update this PR to be compatible with those. |
|
I'm on it! neubig can track my progress at all-hands.dev |
Update the PR review example README to document the new lmnr-project-api-key input for Laminar trajectory uploads.
|
I've reviewed PR #1927 and updated this PR to be fully compatible with the changes made to the PR review process. SummaryPR #1927 refactored the PR review workflow to use a reusable composite GitHub Action. This branch already had the Laminar support properly integrated into:
New ChangeI added documentation for the
Checklist
The PR is now ready for review at #1947 |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Address review feedback to make it clear that the workflow will still function if LAMINAR_ACTIONS_API_KEY is not configured.
|
@OpenHands pls merge from main and resolve merge conflicts |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
f98806e to
6861bd6
Compare
|
Successfully merged main into the Summary of ChangesThe merge conflicts in two files were resolved:
The branch now includes all the latest changes from main, including:
|
deffe75 to
828821a
Compare
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary
This PR enables Laminar observability in the PR review workflow, allowing trajectories to be uploaded for monitoring and debugging.
Changes
LMNR_PROJECT_API_KEYenvironment variable to the "Run PR review" stepLAMINAR_ACTIONS_API_KEYsecretHow it works
The software-agent-sdk's Laminar integration looks for the
LMNR_PROJECT_API_KEYenvironment variable to initialize observability. When set, the SDK will:maybe_init_laminar()LaminarLiteLLMCallbackto litellm callbacksRequirements
The
LAMINAR_ACTIONS_API_KEYsecret must be configured in the repository settings for trajectories to be uploaded.@neubig can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:7c09349-pythonRun
All tags pushed for this build
About Multi-Architecture Support
7c09349-python) is a multi-arch manifest supporting both amd64 and arm647c09349-python-amd64) are also available if needed