Update sources field #222
Update sources field #222
Conversation
data/core.yaml
Outdated
| @@ -801,6 +801,11 @@ en: | |||
| field_source: add source | |||
| field_source_label: Source for {field_name} | |||
| field_source_placeholder: URL, newspaper article, book... | |||
| source: | |||
| main_input: General source | |||
| name: Name of the source | |||
There was a problem hiding this comment.
Since the subfields are already part of the Sources field, we don’t need to repeat “source” here. I don’t think users will confuse this with a field for the name of the feature.
On that note, we should rename the Sources field back to just “Source”, in anticipation of a different solution for tagging multiple sources. Otherwise, the user might think each line is for a different source. The placeholders would guard against that, but a placeholder doesn’t appear when the subfield has some text in it.
There was a problem hiding this comment.
I agree that the field should be named "Source" now and I've been trying to find where the field name is defined, but I wasn't able to.
I found the preset definition in id-tagging-schema, but I believe this refers to the Sources field available after creating a changeset on OSM. It is possible that this preset is also used for the OHM Sources field because it is linked to the source key. Does it make sense to change it?
There was a problem hiding this comment.
We have a general mechanism for providing (or overriding) strings used for individual fields or presets:
Lines 2528 to 2541 in 5cfff58
If you search for custom_presets in the codebase, you can see where we prioritize these strings over the ones that come from id-tagging-schema.
The same preset is used in both situations. If you think it would be confusing to refer to just one “Source” in the save panel, we could add the same additional source fields you were planning to that panel, or we could split the field so that one field is universal to every selected feature, while the other only appears on the save panel. Two fields can correspond to the same raw key, as long as they have unique field IDs.
This PR aims to redesign the "Sources" field for the
source=andsource:*=keys.The main change is the addition of extra rows on the Sources field that each map to a subkey, like
source:nameorsource:url. In these rows, users will be able to assign values directly to the subkeys, something that was only possible before by manually adding these keys in the tag editor.