Added tests for Login #41
Conversation
project_admin/tests.py
Outdated
| request_url = self.project_info_url.format(self.invalid_token) | ||
| response = requests.get(request_url) | ||
| self.assertEqual(response.status_code, 401) | ||
|
|
|
Codeclimate is raising an issue regarding refactoring which I feel isn't possible to fix. Travis issue will be solved when |
|
@rosygupta can you add vcrpy to the Pipfile in this PR? If you add it, the Travis build should use the Pipfile from here. The reason it's not currently there is because you're the first to submit vcrpy tests for this repo 😄 |
|
@mcescalante can you please refer to my discussion with @gedankenstuecke on slack? As I already mentioned in the PR description here, I am facing some issue with |
|
@mcescalante The issue I was facing, its the same issue that is hitting Travis and its failing the build. This seems like a legit bug with |
|
@rosygupta yeah I can see that, I just read through the issues. I'll probably leave this until a bit later this afternoon when I have a minute to see if I can dig further into it. Odd issue! |
|
Ok, I added the |
| def test_invalid_token(self): | ||
| request_url = self.project_info_url.format(self.invalid_token) | ||
| response = requests.get(request_url) | ||
| self.assertEqual(response.status_code, 401) |
There was a problem hiding this comment.
@rosygupta I have a doubt on why would we require these tests, Usually tests are written to test the lines that we wrote or we could change. But here the test_invalid_token and test_valid_token are testing the API interface of openhumans which doesn't belong to this project (It belongs to https://github.com/OpenHumans/open-humans ), it's behaviour changes only when something in the OpenHumans main repository is changed.
So what could be a reason behind dropping these two tests in here in oh-proj-management? when these tests doesn't test anything related to oh-proj-management code?
Let me know if I am wrong in my understanding. Thank You.
There was a problem hiding this comment.
@eeshadutta In order to use this app, oh-proj-management, it is required to enter a (valid) token in. Because our app oh-proj-management does check token validity in order to decide on login success or failure, it makes sense to test that our communications between oh-proj-management and the main site (open-humans) work as expected for both token exchanges and the actual login in our app (which also uses those tokens). Let me know if this clears things up at all, I would be happy elaborate!
#29
Added tests for login. Some doubts and issues:
vcrpyinstallation usingpipenvgives me error as discussed with @gedankenstuecke . So I intsalledvcrpylocally using pip and coded. Would be lovely if somebody else could add thevcrpyto thePipfilefor the same to work.vcris required. Since the login view test (test_login_success) can perform the same functionality.