Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync openbsd net80211 #453

Merged
merged 13 commits into from
Dec 17, 2020
Merged

Sync openbsd net80211 #453

merged 13 commits into from
Dec 17, 2020

Conversation

pigworlds
Copy link
Contributor

Sync latest patches from openbsd net80211

@pigworlds
Sync changes from openbsd
d68cdba
@pigworlds
Kill unused IEEE80211_RADIOTAP_HWQUEUE.
0ad7c7b
@pigworlds
The command value of the _IOC() macro is limited to values [0..255].
97972cc
@pigworlds
Add missing #if's to fix build without bpf(4).
68ebb58
@pigworlds
The IEEE80211_F_HIDENWID flag is now part of ic_userflags, not ic_flags.
fdc267e
@pigworlds
Improve processing of lost frames during 802.11 Rx aggregation.
b945fbb
@pigworlds
Use BA agreement immediately after it is requested by the AP.
cf2e837
@pigworlds
Fix gapwait accounting.
3012af3
@pigworlds
Fix 802.11 RSN capabilities announced to peers.
e848940
@pigworlds
Flush reorder buffer after gap timeout, otherwise the frames remain i…
a9fba6e 
…n the buffer until the next frame is received.
@pigworlds
Disable A-MSDU support again.
9a59277
@pigworlds
Ignore trailing data in A-MSDU frame buffers if it is smaller than th…
3409b6f 
…e Ethernet header size.
@pigworlds
Fix double-free on error in ieee80211_amsdu_decap().
21ccac9
@pigworlds pigworlds mentioned this pull request Dec 16, 2020
Merged
@zxystd
Copy link
Collaborator

zxystd commented Dec 16, 2020

Thank you for the update. I have sync the code in my private branch too and haven't push to the repo.
image
About our driver, iwn needs AMSDU enabling and others not, so I added a capability flag on it, just enable AMSDU inside AMPDU on iwn.
image

@zxystd
Copy link
Collaborator

zxystd commented Dec 16, 2020 •
edited
Loading

Update: for mvm cards which are before 9000 series, there are bugs in the firmware when enabling AMSDU inside AMPDU, so this flag is necessary I think.

I will take sometime to review and see how to deal with it.

@pigworlds
Copy link
Contributor Author

The AMSDU isn't enabled in net80211 globally. I've test enabling AMSDU in iwn and see slight speed increase. Conditionally enable AMSDU is a better approach.

According to your logs, you haven't pick up this patch that disable AMSDU globally again. The comment says need more work for iwm 9k and iwx to be done.

@zxystd zxystd merged commit 36c2df9 into OpenIntelWireless:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pigworlds @zxystd