Changed pre-commit formatter from Black to Ruff #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LMK if I can do anything to improve it! |
|
@SuibhneOFoighil, I'll test on Windows for you! |
Notnaton
requested changes
Apr 2, 2024
Comment on lines
+53
to
-59
| ruff = "^0.3.4" | ||
|
|
||
| [tool.poetry.extras] | ||
| os = ["opencv-python", "pyautogui", "plyer", "pywinctl", "pytesseract", "sentence-transformers", "ipywidgets", "torch", "timm"] | ||
| safe = ["semgrep", "yaspin"] | ||
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| black = "^23.10.1" |
There was a problem hiding this comment.
Move ruff to dev.dependencies
|
Hi @SuibhneOFoighil, thanks for tackling this and thanks @Notnaton and @dheavy for testing! As Anton said I think it would be smart to move it to dev dependencies, then will merge. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
Added Ruff, changed pre-commit script and relevant docs (contributing.md)
Reference any relevant issues (e.g. "Fixes #000"):
Fixes "Change formatter from Black to Ruff #849"
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.mddocs/ROADMAP.mdOS Tests (optional but appreciated):