Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed disable_telemetry being overwritten to False #1442

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fixed disable_telemetry being overwritten to False #1442

merged 1 commit into from
Sep 26, 2024

Conversation

CyanideByte
Copy link
Contributor

Describe the changes you have made:

  • disable_telemetry was reading env var too early and being overwritten by set_attributes
  • Moved reading of the env var to after set_attributes initializes the defaults
  • This fixes the setting not using the environment variable

Reference any relevant issues (e.g. "Fixes #000"):

Fixes #1410

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@CyanideByte CyanideByte mentioned this pull request Sep 5, 2024
Open
@KillianLucas KillianLucas changed the base branch from main to development September 26, 2024 07:08
@KillianLucas KillianLucas merged commit bc3ea85 into OpenInterpreter:development Sep 26, 2024
0 of 2 checks passed
@CyanideByte CyanideByte deleted the disable_telemetry_fix branch September 26, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KillianLucas KillianLucas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show option to skip future "Was Open Interpreter helpful?" messages
2 participants
@CyanideByte @KillianLucas