Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli crash during screenshot generation #884

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix cli crash during screenshot generation #884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88f1a56
fix: CLI crash due to RGBA handling during screenshot generation
double-thinker Jan 8, 2024
6e350fc
refactor: use buffer instead remp file to save/read the screenshot.
double-thinker Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions interpreter/core/computer/display/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,18 @@
import base64
import os
import pprint
import subprocess
import tempfile
import time
import warnings
from io import BytesIO

import matplotlib.pyplot as plt
import requests
from PIL import Image

from ..utils.recipient_utils import format_to_recipient

# Still experimenting with this
# from utils.get_active_window import get_active_window

try:
import cv2
import numpy as np
import pyautogui
except:
Expand Down Expand Up @@ -70,8 +65,6 @@ def screenshot(self, show=True, quadrant=None, active_app_only=False):
)
return

temp_file = tempfile.NamedTemporaryFile(suffix=".png", delete=False)

if quadrant == None:
# Implement active_app_only!
if active_app_only:
Expand Down Expand Up @@ -103,30 +96,20 @@ def screenshot(self, show=True, quadrant=None, active_app_only=False):
else:
raise ValueError("Invalid quadrant. Choose between 1 and 4.")

screenshot.save(temp_file.name)

# Open the image file with PIL
img = Image.open(temp_file.name)

# Delete the temporary file
try:
os.remove(temp_file.name)
except Exception as e:
# On windows, this can fail due to permissions stuff??
# (PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\killi\\AppData\\Local\\Temp\\tmpgc2wscpi.png')
if self.computer.verbose:
print(str(e))
# IPython interactive mode auto-displays plots, causing RGBA handling issues, possibly MacOS-specific.
screenshot = screenshot.convert("RGB")

if show:
# Show the image using matplotlib
plt.imshow(np.array(img))
plt.imshow(np.array(screenshot))

with warnings.catch_warnings():
# It displays an annoying message about Agg not being able to display something or WHATEVER
warnings.simplefilter("ignore")
plt.show()

return img
return screenshot

def find_text(self, text, screenshot=None):
# Take a screenshot
Expand Down