fix: Update request method in windows Client interface to blocking call. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongli Chen <honglich@amazon.com>
Honglichenn
force-pushed
the
honglich/update_timeout
branch
from
1bcba01 to
286dfc6
Compare
ddneilson
reviewed
Mar 22, 2024
moorec-aws
previously approved these changes
Mar 22, 2024
moorec-aws
approved these changes
Mar 22, 2024
ddneilson
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In the WindowsClientInterface, it should wait indefinitely instead of having a timeout.
What was the solution? (How)
DEFAULT_NAMED_PIPE_SERVER_TIMEOUT_IN_SECONDSto control the Server timeout separately.What is the impact of this change?
The request method will become a blocking call aligning to the behavior that we have in Linux.
How was this change tested?
All tests passed
Was this change documented?
Design doc is updated as well.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.