fix: Add delete permission to thesecure_open
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honglichenn
force-pushed
the
honglich/delete_permission
branch
from
c68e930 to
9b1ef0f
Compare
Honglichenn
changed the title
delete permission to thesecure_opendelete permission to thesecure_open
Honglichenn
force-pushed
the
honglich/delete_permission
branch
from
37a6b0b to
a8c421e
Compare
ddneilson
approved these changes
Mar 24, 2024
jericht
approved these changes
Mar 24, 2024
Signed-off-by: Hongli Chen <honglich@amazon.com>
Honglichenn
force-pushed
the
honglich/delete_permission
branch
from
d65483a to
c1cc61b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The Delete permission is missing in the
secure_openin the Windows. It will cause that the connection file is not able to be deleted .What was the solution? (How)
Add the permission to the
secure_opento allow the cleanup to clean up the files.What is the impact of this change?
connection file should be deleted successfully.
How was this change tested?
Due to an unexpected behavior within the system, I encountered limitations in directly testing this change. Specifically, files located under
C:\Users\user_namecan be deleted without requiring delete permissions. Therefore, One of our test can delete the file without the delete permissions. Want to mention that permission inheritance has been explicitly disabled for these files, yet deletion is still possible. I need to investigate this issue outside of this PR.I manually check the
deletepermission of the file create by thesecure_opento confirm that the file owner have the permission to read, write and delete the file. So the permissions are updated.Was this change documented?
N/A
Is this a breaking change?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.