Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon] Add links in dynamic and ComObj section #48

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

olterion
Copy link
Contributor

@olterion olterion commented Sep 4, 2024

Add links for quick access from dynamic to ParameterRef and ComObjectRef items

Add links for quick access from dynamic to ParameterRef and ComObjectRef items
@thewhobox
Copy link
Member

thewhobox commented Sep 6, 2024

It seems the margin is wrong.
The Combobox gets to high
image
Have a look here, what i already use: https://github.com/OpenKNX/Kaenx-Creator/blob/master/Kaenx.Creator/Controls/ParameterRefView.xaml#L120

@thewhobox
Copy link
Member

While testing i found wo bugs (they were my fault):

  • If im in the Dynamic Section of the core application (not in a module) i always get redirect to the moduels section.
  • TextFilter throws an error if you not visited the Parameters List before clicking on the hyperlink

Comboboxes were too high due to wrong margin for textblocks from the links
@olterion
Copy link
Contributor Author

I changed the margin of the Textboxes, so the ComboBoxes getting not too high anymore.

@thewhobox thewhobox merged commit 915a5a2 into OpenKNX:master Sep 10, 2024
1 check passed
@olterion olterion deleted the addon_add_ref_links branch September 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants