fix stopwords in areatitles #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…backend-regressiontests
…backend-regressiontests
chreman
added a commit
to chreman/Headstart
that referenced
this pull request
Oct 13, 2021
…itlestopwords fix stopwords in areatitles Former-commit-id: 88ede04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the root cause of two edge cases, which sometimes intersect: documents with single (or duplicate) documents that have no keywords. In theses cases, two bugs could occur individually or simultaneously: appearance of stopwords in bubble titles that should be excluded; wrongly increased number of bubbles.
The bubble title replacement was not working at the correct level: instead of replacing single bubble titles for one (or multiple) documents, multiple area titles were created according to the count of documents with missing subjects.
This issue has now been fixed, resulting in correct number of bubbles and preventing appearance of stopwords in bubble titles.