-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring (Map): initial phase #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commented out most of the legacy code components prototypes force layout first working version
zoom in/out (no animation yet) resize in zoom bubbles order on hover/zoom
selecting, hovering, deselecting the resize on hover is just prototype
with known bug: zooming to a different bubble
prepared middleware for queued actions
any action that changes the map state is queued during the animation bubble and paper order moved to store known bug: hovered paper after zoom in
text truncating doesn't work again
hyphenation + shave + highlighting
middlewares in intermediate bubble titles set with dangerouslySetInnerHTML
chreman
added a commit
to chreman/Headstart
that referenced
this pull request
Oct 13, 2021
…toring-map-initial Refactoring (Map): initial phase Former-commit-id: d159b9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the 1st part of the knowledge map component refactoring. I refactored everything at once (chart + bubbles + papers).
The new code can be tested by building the application with MODERN_FRONTEND=true.
Main features:
Libraries:
react-hyphen
. I use it for hyphenating the paper content.d3
sub-libraries were added (somehow d3 didn't work without them in the new code)Redux:
Components:
KnowledgeMap
,Chart
,Bubble
andPaper
.BubbleTitle
component encapsulates the old highlighting + hyphenating + truncating logic.Legacy code:
canvas.js
,bubbles.js
,papers.js
andlist.js
.Testing:
Known bugs: