Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature element ordering (depends on PR #13) #14

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

rbachleitner
Copy link
Collaborator

@rbachleitner rbachleitner commented Sep 10, 2018

Description

We need a way to control the order of elements rendered to the SVG Chart as it influences element visibility. I introduced a very simple new component so I could render a Paper or Bubble Component dynamically depending on the value of the flag 'type' on the Paper/Bubble object.
A more naive approach of rendering a <div> with a v-for directive didn't work out the way I expected it to.

Also introduces a computed property sortedPapersAndBubbles on the App Component, which takes the papers and bubbles arrays, throws them in a single array, and returns a sorted array according to an 'order' flag on the element objects.
This should make implementing hover behaviour (bring papers/bubbles to front/back) very easy.

Checklist:

  • My code follows the style guidelines of this project

  • The change is fulfilling its purpose and works in all browsers/environments

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

  • The change is in line with the design goals of Head Start

  • The changes fit our coding style

  • The changes do not negatively affect the different stakeholders of Headstart (end users, developers, designers, maintainers, deployers, users of Head Start as a library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants