Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] [XKore] add option to auto reply pincode request #3365

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alisonrag
Copy link
Contributor

let user decide if openkore or client will reply the pincode request

already implemented at Receive.pm
let user decide if openkore or client will reply pincode
@ya4ept
Copy link
Contributor

ya4ept commented Mar 4, 2021

What about:
} elsif ($args->{flag} == 2) {
} elsif ($args->{flag} == 2 || $args->{flag} == 4) {

@ya4ept
Copy link
Contributor

ya4ept commented Mar 30, 2021

under what scenario is it useful to use XKore 1 mode and turn off XKore_autoReplyPinCode ?
how about deleting this code?

	if(($config{XKore} eq "1" || $config{XKore} eq "3") && !$config{XKore_autoReplyPinCode}) {
		$timeout{master}{time} = time;
		return;
	}

@alisonrag
Copy link
Contributor Author

under what scenario is it useful to use XKore 1 mode and turn off XKore_autoReplyPinCode ?
how about deleting this code?

	if(($config{XKore} eq "1" || $config{XKore} eq "3") && !$config{XKore_autoReplyPinCode}) {
		$timeout{master}{time} = time;
		return;
	}

uKore bypass auto send pincode using client, if openkore send too it cause DC, this is why i added this key, if user want to use openkore or the bypass to send the pincode

@ya4ept
Copy link
Contributor

ya4ept commented Apr 16, 2021

uKore bypass auto send pincode using client

the user enters the PIN code by himself?

@alisonrag
Copy link
Contributor Author

uKore bypass auto send pincode using client

the user enters the PIN code by himself?

user configure a file and the bypass send the inputs to client insted of openkore

@@ -3912,7 +3912,7 @@ sub login_pin_code_request {
# This is ten second-level password login for 2013/3/29 upgrading of twRO
my ($self, $args) = @_;

if($args->{flag} ne 0 && ($config{XKore} eq "1" || $config{XKore} eq "3")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you decide to remove this check?
$args->{flag} ne 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants