-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config] [XKore] add option to auto reply pincode request #3365
base: master
Are you sure you want to change the base?
Conversation
already implemented at Receive.pm
let user decide if openkore or client will reply pincode
What about: |
under what scenario is it useful to use XKore 1 mode and turn off if(($config{XKore} eq "1" || $config{XKore} eq "3") && !$config{XKore_autoReplyPinCode}) {
$timeout{master}{time} = time;
return;
} |
uKore bypass auto send pincode using client, if openkore send too it cause DC, this is why i added this key, if user want to use openkore or the bypass to send the pincode |
the user enters the PIN code by himself? |
user configure a file and the bypass send the inputs to client insted of openkore |
@@ -3912,7 +3912,7 @@ sub login_pin_code_request { | |||
# This is ten second-level password login for 2013/3/29 upgrading of twRO | |||
my ($self, $args) = @_; | |||
|
|||
if($args->{flag} ne 0 && ($config{XKore} eq "1" || $config{XKore} eq "3")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you decide to remove this check?
$args->{flag} ne 0
let user decide if openkore or client will reply the pincode request